Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Enhancement: Support Config Path Override #396

Merged
merged 1 commit into from
Jan 6, 2023
Merged

[ci] Enhancement: Support Config Path Override #396

merged 1 commit into from
Jan 6, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jan 5, 2023

Description

This PR fixes #395.

Summary of Changes

  • Added support for overriding default CONFIG_PATH on run steps.

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Jan 5, 2023
@ppenna ppenna requested a review from iyzhang January 5, 2023 19:42
@ppenna ppenna self-assigned this Jan 5, 2023
iyzhang
iyzhang approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ppenna ppenna merged commit 2f4d9c0 into dev Jan 6, 2023
@ppenna ppenna deleted the enhancement-ci-config-path branch January 6, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[testing] Need to be able to place config file in root directory
2 participants
@ppenna @iyzhang