Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Fixing Flag That Fails to Run Any Tests in Azure Tables Script #431

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Jan 19, 2023

This PR fixes a bug in the azure-tables scripts that cause no tests to run when no make flags are given. I also moved catnip to the end of the test sequence per our discussion today, in case DPDK has any issues that wedge the machine.

@iyzhang iyzhang added the bug Something Isn't Working label Jan 19, 2023
@iyzhang iyzhang requested a review from ppenna January 19, 2023 03:05
@iyzhang iyzhang force-pushed the bugfix-tools-azure-tables-support branch from 9f65854 to 7ebf1da Compare January 19, 2023 03:35
@ppenna
Copy link
Contributor

ppenna commented Jan 19, 2023

Thanks!

@ppenna ppenna changed the title [tools] Fixing flag that fails to run any tests in Azure tables script [tools] Fixing Flag That Fails to Run Any Tests in Azure Tables Script Jan 19, 2023
Copy link
Contributor

@BrianZill BrianZill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about Python to understand how these two if statement combinations differ, but it looks okay to me.

@iyzhang iyzhang force-pushed the bugfix-tools-azure-tables-support branch from 7ebf1da to dded605 Compare January 20, 2023 01:42
@iyzhang iyzhang force-pushed the bugfix-tools-azure-tables-support branch from dded605 to ac45971 Compare January 20, 2023 01:44
@iyzhang iyzhang merged commit f53cfee into dev Jan 20, 2023
@iyzhang iyzhang deleted the bugfix-tools-azure-tables-support branch January 20, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants