Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] 32-Bit Queue Descriptors #441

Merged
merged 1 commit into from
Jan 26, 2023
Merged

[runtime] 32-Bit Queue Descriptors #441

merged 1 commit into from
Jan 26, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jan 23, 2023

Description

This PR closes #430.

Summary of Changes

  • Changed QDesc to use a u32 type representation for queue descriptors.
  • Fixed IoQueueTable accordingly.
  • Fixed concerned unit tests.

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Jan 23, 2023
@ppenna ppenna self-assigned this Jan 23, 2023
BrianZill
BrianZill approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@BrianZill BrianZill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ppenna ppenna merged commit 681fb8b into dev Jan 26, 2023
@ppenna ppenna deleted the enhancement-runtime-qdesc branch January 26, 2023 17:35
@ppenna ppenna mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianZill BrianZill BrianZill approved these changes

@iyzhang iyzhang Awaiting requested review from iyzhang

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[runtime] Queue Descriptors Should Be 32 Bit
2 participants
@ppenna @BrianZill