Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Improving TCP Echo Program #476

Merged
merged 1 commit into from
Feb 14, 2023
Merged

[examples] Improving TCP Echo Program #476

merged 1 commit into from
Feb 14, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Feb 13, 2023

Description

This PR improves the TCP Echo program in several points:

  • Added dynamic payload generation on client side
  • Added payload checking on client side
  • Added support for running a running a fixed number of requests.

@ppenna ppenna self-assigned this Feb 13, 2023
@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Feb 13, 2023
iyzhang
iyzhang approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ppenna ppenna force-pushed the enhancement-examples-tcp-echo branch from 13d3c77 to 799f9c4 Compare February 13, 2023 20:55
@ppenna ppenna merged commit 5c22286 into dev Feb 14, 2023
@ppenna ppenna deleted the enhancement-examples-tcp-echo branch February 14, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppenna @iyzhang