[catmem] Don't Close Pipe When EoF is Reached #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppenna
force-pushed
the
bugfix-catmem-eof
branch
from
8b420c8
to
796687c
Compare
iyzhang
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
The changes to catmem conflict with my changes in PR #486. It should be easy to replace the ring field in CatmemQueue without disturbing any of the rest of the code, but I'm not sure what order in which these two PRs should go in. Otherwise, the changes look good to me.
ppenna
force-pushed
the
bugfix-catmem-eof
branch
from
796687c
to
fdc5582
Compare
Yes, let us work together on your enhancement changes to make sure that they also cover this bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #480
Summary of Changes
demikernel_ci.