[runtime] Move OperationResult out of inetstack #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppenna
requested changes
Mar 6, 2023
iyzhang
force-pushed
the
enhancement-runtime-move-operation-result
branch
from
ddac36a
to
7f2e10e
Compare
iyzhang
force-pushed
the
enhancement-runtime-move-operation-result
branch
from
7f2e10e
to
0c1bfea
Compare
ppenna
approved these changes
Mar 7, 2023
ppenna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the OperationResult data structure out of the inetstack. This move lets us remove the dependency on the inetstack from the libOSes that do not use it. I also deprecated the QResult data structure as I believe it is not actually used. We can decide later whether to rename the OperationResult data structure or have separate result data structures for each libOS.