[inetstack] Fail to Close Bound and Unbound Sockets #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
approved these changes
Mar 7, 2023
| let cause: String = format!("cannot close a socket that is closing (qd={:?})", qd); | ||
| error!("do_close(): {}", &cause); | ||
| return Err(Fail::new(libc::ENOTSUP, &cause)); | ||
| }, | ||
| } | ||
| }, | ||
| _ => return Err(Fail::new(libc::EBADF, "bad queue descriptor")), | ||
| }; | ||
| inner.addresses.remove(&SocketId::Passive(addr)); |
There was a problem hiding this comment.
Can you add a TODO comment to remove active sockets from the addresses table when the close completes?
| @@ -459,7 +459,7 @@ fn tcp_bad_listen() { | |||
| Err(e) if e.errno == libc::EINVAL => (), | |||
| _ => panic!("invalid call to listen() should fail with EINVAL"), | |||
| }; | |||
| safe_close_passive(&mut libos, sockqd); | |||
| safe_close_active(&mut libos, sockqd); | |||
There was a problem hiding this comment.
Inside the safe_close_active function, the error still says passive socket.
ppenna
force-pushed
the
bugfix-inetstack-bind
branch
2 times, most recently
from
72f1872
to
8e1d719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
safe_close_passive#512Summary of Changes
close()to succeed when closing bound and unbound socketssafe_close_active()to correctly close active sockets.