[pdpix] Add async_close API #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppenna
reviewed
Mar 8, 2023
iyzhang
force-pushed
the
enhancement-pdpix-async-close
branch
2 times, most recently
from
7322f6f
to
99351a4
Compare
ppenna
approved these changes
Mar 9, 2023
include/demi/types.h
Outdated
| @@ -61,6 +61,7 @@ extern "C" | |||
| DEMI_OPC_POP, /**< Pop operation. */ | |||
| DEMI_OPC_ACCEPT, /**< Accept operation. */ | |||
| DEMI_OPC_CONNECT, /**< Connect operation. */ | |||
| DEMI_OPC_CLOSE, /**< Close operation. */ | |||
There was a problem hiding this comment.
Could you add an extra space here, so that comments align up?
iyzhang
force-pushed
the
enhancement-pdpix-async-close
branch
from
99351a4
to
f713064
Compare
ppenna
force-pushed
the
enhancement-pdpix-async-close
branch
from
f713064
to
302ebef
Compare
ppenna
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of several commits adding support for asynchronous close to Demikernel for issue #520 . This PR adds the API, the returned result in the runtime and unimplemented cases for all of the libOSes.