[runtime] Improve Split Functionality in DemiBuffer
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppenna
changed the title
DemiBuffer
ppenna
force-pushed
the
enhancement-runtime-demibuffer
branch
2 times, most recently
from
cc83c47
to
2058821
Compare
iyzhang
approved these changes
Mar 17, 2023
| /// - The target [DemiBuffer] must be a single buffer segment (not a chain). | ||
| /// - The target [DemiBuffer] should be large enough to hold `offset`. | ||
| /// | ||
| pub fn split_front(&mut self, offset: usize) -> Result<Self, Fail> { |
There was a problem hiding this comment.
To eliminate duplicate code, we should probably have a shared function here that gives both halves back and then split_front and split_back just return the front_half or back_half.
There was a problem hiding this comment.
Sure... I merged the two functions in one, called split()
ppenna
force-pushed
the
enhancement-runtime-demibuffer
branch
from
2058821
to
66889f8
Compare
This commit partially addresses #542 - Renamed DemiBuffer::split_off() to DemiBuffer::split_back().
Improved API documentation for DemiBuffer::split_back().
This commit introduces minor enhancements in DemiBuffer::split_back(): - Introduced DemiBuffer::is_multi_segment() helper function. - Simplified logic for sanity checking split_back() operation. - Improved comments on the split_back() function.
Improved unit test for DemiBuffer::split_back().
This commit partially addresses #542 - Introduced the DemiBuffer::split_front() operation. - Introduced a unit test for DemiBuffer::split_front().
ppenna
force-pushed
the
enhancement-runtime-demibuffer
branch
from
66889f8
to
31edf07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #542
Summary of Changes
DemiBuffer::split_off()toDemiBuffer::split_back()DemiBuffer::split_back()DemiBuffer::split_front()DemiBuffer::split_front()