[pdpix] Fixed Size demi_pop
#547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppenna
force-pushed
the
enhancement-pdpix-pop
branch
3 times, most recently
from
e2f6bdc
to
8ce9f46
Compare
iyzhang
approved these changes
Mar 20, 2023
| @@ -373,10 +373,20 @@ impl CatcollarLibOS { | |||
| } | |||
|
|
|||
| /// Pops data from a socket. | |||
| pub fn pop(&mut self, qd: QDesc) -> Result<QToken, Fail> { | |||
| trace!("pop() qd={:?}", qd); | |||
| pub fn pop(&mut self, qd: QDesc, size: Option<usize>) -> Result<QToken, Fail> { | |||
There was a problem hiding this comment.
We should probably also check that the size is not above some max threshold
There was a problem hiding this comment.
Sure. This requires major work, thus I created a issue to keep track of this: #559
ppenna
force-pushed
the
enhancement-pdpix-pop
branch
from
8ce9f46
to
d790e3e
Compare
This commit partially addresses #499
ppenna
force-pushed
the
enhancement-pdpix-pop
branch
from
d790e3e
to
80a3e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #499
Summary of Changes
demi_pop()