-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scheduler] Rename future abstractions #555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
from
March 17, 2023 15:43
f175912
to
12ca1c2
Compare
iyzhang
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
2 times, most recently
from
March 17, 2023 17:10
aa6dfe9
to
b2ecbfc
Compare
ppenna
reviewed
Mar 17, 2023
iyzhang
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
from
March 17, 2023 17:24
b2ecbfc
to
b35ea36
Compare
ppenna
approved these changes
Mar 17, 2023
iyzhang
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
from
March 18, 2023 19:48
40bc1fe
to
bcd3741
Compare
ppenna
requested changes
Mar 20, 2023
ppenna
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
2 times, most recently
from
March 20, 2023 18:28
7c68ca9
to
c547624
Compare
iyzhang
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
4 times, most recently
from
March 20, 2023 22:04
813b8df
to
8a48bf0
Compare
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
ppenna
reviewed
Mar 20, 2023
iyzhang
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
2 times, most recently
from
March 21, 2023 01:35
a640e27
to
fb6663e
Compare
ppenna
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
from
March 21, 2023 12:38
fb6663e
to
d08b996
Compare
ppenna
approved these changes
Mar 21, 2023
iyzhang
force-pushed
the
enhancement-runtime-scheduler-renaming
branch
from
March 21, 2023 16:35
d08b996
to
972caf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of some of the abstractions in the scheduler are a bit confusing from Demikernel's point of view and they do not reflect our needs. First, we've renamed Future to Coroutine (even though they are not strictly coroutines). This is our basic unit of computation for performing I/O. Next, this PR creates a Task abstraction to replace the previous FutureResult abstraction. The scheduler uses Tasks for scheduling now instead of opaque Futures as before. Thus, you must wrap a Future/Coroutine in a Task before you can insert it into the scheduler because the scheduler no longer knows about generic Futures. This means that we are able to have a better view into what coroutines are running (and our background coroutines are also wrapped in Task, rather than being directly scheduled). This addresses issue #529