Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[catnip] Append an empty string at eal_init args to be skipped #558

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

ihchoi12
Copy link
Contributor

Description

This PR solves #536

Summary of Changes

Just append an empty string to eal_init in the default.yaml configuration file.

@ihchoi12 ihchoi12 changed the title Append an empty string at eal_init args to be skipped [Catnip] Append an empty string at eal_init args to be skipped Mar 20, 2023
@ihchoi12 ihchoi12 changed the title [Catnip] Append an empty string at eal_init args to be skipped [catnip] Append an empty string at eal_init args to be skipped Mar 20, 2023
@ihchoi12 ihchoi12 closed this Mar 20, 2023
@ihchoi12 ihchoi12 reopened this Mar 20, 2023
@iyzhang
Copy link
Contributor

iyzhang commented Mar 22, 2023

Thanks for doing this! Can you do a git rebase against dev and squash your commits into one commit?

@ihchoi12
Copy link
Contributor Author

Done. Thanks for the suggestion!

@carvalhof
Copy link
Contributor

Another possibility is to insert a string (e.g., "") at the first position of eal_init_refs vector in the initialize_dpdk function. Branch bugfix-dpdk-eal presents this possibility.

@ppenna ppenna self-assigned this Mar 23, 2023
@ppenna ppenna added the bug Something Isn't Working label Mar 23, 2023
@ppenna ppenna merged commit 48cd247 into microsoft:dev Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants