Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[catnip] Bug Fix: integer comparison in catnip:memorypool #574

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

carvalhof
Copy link
Contributor

Description

Summary of Changes

  • Converted the num_bytes (from u16 to usize) to compare against size (usize).

@ppenna ppenna self-requested a review March 24, 2023 11:14
@ppenna ppenna self-assigned this Mar 24, 2023
@ppenna ppenna added the bug Something Isn't Working label Mar 24, 2023
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna merged commit 72ea37b into dev Mar 24, 2023
@ppenna ppenna deleted the bugfix-catnip-alloc_mbuf branch March 24, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[catnip] MemoryPool::alloc_mbuf Function Makes Incorrect Allocation Size Comparison
2 participants