Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Drop Use of new_uninit #596

Merged
merged 1 commit into from
Apr 6, 2023
Merged

[build] Drop Use of new_uninit #596

merged 1 commit into from
Apr 6, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 3, 2023

Description

Summary of Changes

  • Drop use of new_uninit unstable feature

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Apr 3, 2023
@ppenna ppenna assigned ppenna and unassigned ppenna Apr 3, 2023
iyzhang
iyzhang approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna
[build] Enhancement: Drop Use of new_uninit
3ccabda 
This commit is a partial fix for
#172
@ppenna ppenna force-pushed the enhancement-build-drop-features branch from 90e01ae to 3ccabda Compare April 6, 2023 12:11
@ppenna ppenna merged commit b596f4f into dev Apr 6, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-build-drop-features branch April 6, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees
No one assigned
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppenna @iyzhang