Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catloop] Collisions on Queue Token Space #623

Merged
merged 2 commits into from
Apr 10, 2023
Merged

[catloop] Collisions on Queue Token Space #623

merged 2 commits into from
Apr 10, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 6, 2023 •
edited

Description

This PR closes #622

Summary of Changes

  • Improved some error logs in Catloop LibOS
  • Fixed collisions in queue token space of Catloop LibOS
    • Queue tokens from Catmem LibOS are now registered in a different table

@ppenna ppenna added the bug Something Isn't Working label Apr 6, 2023
@ppenna ppenna self-assigned this Apr 6, 2023
iyzhang
iyzhang approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me, but we should definitely do something with this code when we unify the scheduler to handle multiple libOSes. Should we file an issue?

src/rust/catloop/mod.rs Show resolved Hide resolved
src/rust/catloop/mod.rs Show resolved Hide resolved
@ppenna ppenna merged commit b685b15 into dev Apr 10, 2023
10 checks passed
@ppenna ppenna deleted the bugfix-catloop-qts branch April 10, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[catloop] Collisions on Queue Token Space
2 participants
@ppenna @iyzhang