Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Add .txt suffix to log files #629

Merged
merged 1 commit into from
Apr 10, 2023
Merged

[test] Add .txt suffix to log files #629

merged 1 commit into from
Apr 10, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Apr 7, 2023

This PR closes #435

ppenna
ppenna approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@iyzhang iyzhang force-pushed the enhancement-test-use-txt-suffix branch from a5db5f9 to fe64ab8 Compare April 7, 2023 18:03
@ppenna ppenna merged commit b1a3215 into dev Apr 10, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-test-use-txt-suffix branch April 10, 2023 14:34
@ppenna ppenna mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tools] Use .txt suffix for log files to make Github uploads easier
2 participants
@iyzhang @ppenna