Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catmem] Redimensioning Ring Buffer #636

Merged
merged 1 commit into from
Apr 11, 2023
Merged

[catmem] Redimensioning Ring Buffer #636

merged 1 commit into from
Apr 11, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 10, 2023

Description

This commit closes #589

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Apr 10, 2023
@ppenna ppenna self-assigned this Apr 10, 2023
iyzhang
iyzhang approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume that this is because of contention that we need a bigger buffer?

@ppenna
Copy link
Contributor Author

ppenna commented Apr 11, 2023

LGTM, I assume that this is because of contention that we need a bigger buffer?

Yes. This mitigates contention, but does not solve it.

@ppenna ppenna merged commit 4a3361c into dev Apr 11, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-catmem-ring-buffer-size branch April 11, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[catmem] Increase Size of Shared Ring Buffer to Mitigate Contention
2 participants
@ppenna @iyzhang