Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Remove panics from pipe-open system test #639

Merged
merged 1 commit into from
Apr 11, 2023
Merged

[test] Remove panics from pipe-open system test #639

merged 1 commit into from
Apr 11, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Apr 10, 2023

This PR removes panic from examples/pipe-open and adds a reference to a new issue for fixing the error handling clean up of pipes.

@iyzhang iyzhang added the bug Something Isn't Working label Apr 10, 2023
@iyzhang iyzhang self-assigned this Apr 10, 2023
@iyzhang iyzhang mentioned this pull request Apr 10, 2023
Closed
12 tasks
@iyzhang iyzhang changed the title [test] Remove panic from examples/pipe-open [test] Remove panics from pipe-open system test Apr 10, 2023
@iyzhang iyzhang linked an issue Apr 10, 2023 that may be closed by this pull request
[test] Remove unwrap(), expect() and panic() from All Tests #207
Closed
12 tasks
ppenna
ppenna approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

Please reword your commit title so that it follows our code standards.

@iyzhang iyzhang force-pushed the bugfix-test-pipe-open-remove-panic branch from 12865df to d282040 Compare April 11, 2023 17:49
@iyzhang iyzhang removed a link to an issue Apr 11, 2023
[test] Remove unwrap(), expect() and panic() from All Tests #207
Closed
12 tasks
@iyzhang iyzhang merged commit cc7bc63 into dev Apr 11, 2023
10 checks passed
@iyzhang iyzhang deleted the bugfix-test-pipe-open-remove-panic branch April 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@iyzhang iyzhang

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iyzhang @ppenna