[test] Remove panic from collections unit tests #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppenna
reviewed
Apr 14, 2023
ppenna
reviewed
Apr 14, 2023
ppenna
reviewed
Apr 14, 2023
ppenna
reviewed
Apr 14, 2023
ppenna
reviewed
Apr 14, 2023
ppenna
approved these changes
Apr 14, 2023
iyzhang
force-pushed
the
bugfix-test-unit-collections-remove-panic
branch
from
e3d34a7
to
81f7515
Compare
iyzhang
force-pushed
the
bugfix-test-unit-collections-remove-panic
branch
from
81f7515
to
ba57004
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #207 for all of the unit tests in src/rust/collections. It also adds a return value to every test and replaces assert with ensure and assert_eq with the new ensure_eq macro.