Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Remove panic from scheduler unit test #664

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Apr 17, 2023

This PR removes panics, asserts, expects and unwraps from the scheduler unit tests.

@iyzhang iyzhang added the bug Something Isn't Working label Apr 17, 2023
@iyzhang iyzhang requested a review from ppenna April 17, 2023 20:27
@iyzhang iyzhang self-assigned this Apr 17, 2023
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iyzhang iyzhang force-pushed the bugfix-test-unit-scheduler-remove-panic branch from e24c68d to 360d066 Compare April 18, 2023 19:21
@iyzhang iyzhang force-pushed the bugfix-test-unit-scheduler-remove-panic branch from 360d066 to 0f63df9 Compare April 18, 2023 19:34
@iyzhang iyzhang merged commit 89f9576 into dev Apr 18, 2023
10 checks passed
@iyzhang iyzhang deleted the bugfix-test-unit-scheduler-remove-panic branch April 18, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants