Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Remove panic from runtime unit test #665

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Apr 17, 2023

This PR removes panics, asserts, expects and unwraps from the unit tests in the src/rust/runtime directory.

@iyzhang iyzhang added the bug Something Isn't Working label Apr 17, 2023
@iyzhang iyzhang requested a review from ppenna April 17, 2023 20:55
@iyzhang iyzhang self-assigned this Apr 17, 2023
@ppenna ppenna changed the title [test] Bugfix: Remove panic from runtime unit test [test] Remove panic from runtime unit test Apr 18, 2023
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iyzhang iyzhang force-pushed the bugfix-test-unit-runtime-remove-panic branch from 42378c9 to 3f6600a Compare April 18, 2023 21:11
@iyzhang iyzhang merged commit bd29a6a into dev Apr 18, 2023
10 checks passed
@iyzhang iyzhang deleted the bugfix-test-unit-runtime-remove-panic branch April 18, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants