Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Rich CLI for C System Tests #676

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[test] Rich CLI for C System Tests #676

merged 1 commit into from
Apr 20, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 19, 2023 •
edited

Description

This PR closes #152

Summary of Changes

  • Modified system-level tests for the C API to enable constants be overridable by command line arguments.

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Apr 19, 2023
@ppenna ppenna self-assigned this Apr 19, 2023
iyzhang
iyzhang approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/c/tcp-push-pop.c Outdated Show resolved Hide resolved
examples/c/tcp-push-pop.c Outdated Show resolved Hide resolved
@ppenna ppenna merged commit 2bd79be into dev Apr 20, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-tests-c branch April 20, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] System-Level Tests for the C API Should Have a Richer CLI
2 participants
@ppenna @iyzhang