Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Wait Pop After Closing Pipe #683

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[test] Wait Pop After Closing Pipe #683

merged 1 commit into from
Apr 24, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 20, 2023 •
edited

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Apr 20, 2023
@ppenna ppenna self-assigned this Apr 20, 2023
@ppenna ppenna force-pushed the enhancement-test-catmem-pop-wait branch 2 times, most recently from 5ed1dcf to 5ae356b Compare April 24, 2023 14:17
iyzhang
iyzhang approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/rust/pipe-test/pop_wait/client.rs Outdated Show resolved Hide resolved
@ppenna ppenna force-pushed the enhancement-test-catmem-pop-wait branch from 5ae356b to 455997e Compare April 24, 2023 17:59
@ppenna ppenna merged commit c4fbd42 into dev Apr 24, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-test-catmem-pop-wait branch April 24, 2023 18:12
@ppenna ppenna mentioned this pull request Apr 27, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppenna @iyzhang