Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Wait Push After Asynchronous Close #693

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 25, 2023

Description

This PR partially addresses #619

Summary of Changes

  • Fixed push_wait integration test to run the co-routine once before calling close()
  • Added integration test for "attempt to wait for a push() operation to complete after asynchronously closing a pipe."

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Apr 25, 2023
@ppenna ppenna self-assigned this Apr 25, 2023
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna force-pushed the enhancement-test-catmem-push-wait-async branch from ec5464f to 8d02489 Compare April 27, 2023 11:23
@ppenna ppenna merged commit 63982df into dev Apr 27, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-test-catmem-push-wait-async branch April 27, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants