Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pdpix] Have a System-Wide Maximum Size for a Receive Buffer #699

Merged
merged 5 commits into from
Apr 27, 2023
Merged

[pdpix] Have a System-Wide Maximum Size for a Receive Buffer #699

merged 5 commits into from
Apr 27, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 26, 2023

Description

This PR closes #698

Summary of Changes

  • Added a system-wide constant for the maximum size of receive buffers.
  • Changed Catnap LibOS to use that system-wide constant.
  • Changed Catmem LibOS to use that system-wide constant.
  • Changed Catcollar LibOS to use that system-wide constant.
  • Changed Catpowder LibOS to use that system-wide constant.

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Apr 26, 2023
@ppenna ppenna self-assigned this Apr 26, 2023
iyzhang
iyzhang approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me but we might not want to use a global RECVBUF size. For example, RDMA will accommodate up to 1Gb sends and receives.

@ppenna
Copy link
Contributor Author

ppenna commented Apr 27, 2023

The code looks fine to me but we might not want to use a global RECVBUF size. For example, RDMA will accommodate up to 1Gb sends and receives.

Sure. Let us revisit this when we have a RDMA LibOS merged in.

@ppenna ppenna merged commit b133226 into dev Apr 27, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-pdpix-limits branch April 27, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pdpix] Have a System-Wide Maximum Size for a Receive Buffer
2 participants
@ppenna @iyzhang