Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pdpix] Consistent Behavior When listen() with Invalid Backlog Length #700

Merged
merged 5 commits into from
Apr 27, 2023
Merged

[pdpix] Consistent Behavior When listen() with Invalid Backlog Length #700

merged 5 commits into from
Apr 27, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Apr 26, 2023

Description

This PR is a partial fix for #584

Summary of Changes

  • Moved check logic for backlog length to PDPIX layer
  • Added debug assert on Catnap LibOS for backlog length.
  • Added debug assert on Catcollar LibOS for backlog length.
  • Added debug assert on Catloop LibOS for backlog length.

Additional Notes

It was not possible to fix this for Catpowder and Catnip because the legacy test infrastructure would fail. Once we have the new infrastructure enabled for them, we can have the issue closed.

@ppenna ppenna added the bug Something Isn't Working label Apr 26, 2023
@ppenna ppenna self-assigned this Apr 26, 2023
iyzhang
iyzhang requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for those small nits

src/rust/inetstack/mod.rs Show resolved Hide resolved
src/rust/catnap/mod.rs Show resolved Hide resolved
@ppenna
[pdpix] Enhancement: Truncate Backlog Length
638a0b2 
Moved logic for truncating / rounding up backlong length in listen()
to PDPIX layer.

This commit partially addresses
#584
@ppenna
[catnap] Enhancement: Assert Backlog Length
cd3c0d7 
This commit partially addresses
#584
@ppenna
[catloop] Enhancement: Assert Backlog Length
249590e 
This commit partially addresses
#584
@ppenna
[inetstack] Enhancement: Adding FIXME Comment
caa42f6
@ppenna
[catcollar] Enhancement: Assert Backlog Length
01d42db 
This commit partially addresses
#584
@ppenna ppenna merged commit c610992 into dev Apr 27, 2023
10 checks passed
@ppenna ppenna deleted the bugfix-pdpix-listen branch April 27, 2023 13:33
@ppenna ppenna mentioned this pull request Apr 27, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppenna @iyzhang