Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add cleanup to TCP system tests #714

Merged
merged 4 commits into from
May 2, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented May 2, 2023

This PR closes #649. For the tests with Application structs, I added a drop function. For the other tests, I explicitly added close and freesga calls on error.

@iyzhang iyzhang added the enhancement Enhancement Request on an Existing Feature label May 2, 2023
@iyzhang iyzhang requested review from anandbonde and ppenna May 2, 2023 04:02
@iyzhang iyzhang self-assigned this May 2, 2023
examples/rust/tcp-dump.rs Outdated Show resolved Hide resolved
examples/rust/tcp-dump.rs Outdated Show resolved Hide resolved
examples/rust/tcp-pktgen.rs Outdated Show resolved Hide resolved
examples/rust/tcp-pktgen.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, except for these minor suggestions.

@ppenna ppenna force-pushed the enhancement-test-tcp-system-cleanup branch from 3692673 to 4889b6f Compare May 2, 2023 12:53
@ppenna ppenna force-pushed the enhancement-test-tcp-system-cleanup branch from 4889b6f to 2e1fedf Compare May 2, 2023 13:06
@ppenna ppenna merged commit f3ebdf6 into dev May 2, 2023
10 checks passed
@ppenna ppenna deleted the enhancement-test-tcp-system-cleanup branch May 2, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] Clean up state on error in tcp system tests
2 participants