[catnip] Bad Scatter-Gather Allocation/Free #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianZill
reviewed
Apr 11, 2022
BrianZill
reviewed
Apr 11, 2022
tests/sga.rs
Outdated
| //============================================================================== | ||
|
|
||
| /// Size of scatter-gather arrays. | ||
| const SGA_MAX_SIZE: usize = 1280; |
There was a problem hiding this comment.
Might we want to test allocating different sizes, instead of always the same size?
There was a problem hiding this comment.
Nice! I've added tests for 64-byte SGA arrays, to cover the heap-allocated buffers in catnip. Also, as we've discussed, I'll add even more comprehensive tests after I'm done with the re-architecting of this memory management component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #51.
In summary, the pointer arithmetic used for releasing allocated
mbufsis bad. Instead of relying on this technique, I simply changed current code to use the returnedmbufpointer.Since the management of DPDK buffers is not well design, I've also placed a warning, so that we know when we are relying on this allocation strategy.
Finally, I introduce unit-tests that ensure that the current logic works as expected.
This component will be strongly re-architected in a next PR.