Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Tests from Cvdm.ErrorHandling #16

Closed
demystifyfp opened this issue Apr 11, 2019 · 3 comments
Closed

Add missing Tests from Cvdm.ErrorHandling #16

demystifyfp opened this issue Apr 11, 2019 · 3 comments

Comments

@demystifyfp
Copy link
Owner

No description provided.

@demystifyfp demystifyfp mentioned this issue Apr 11, 2019
Closed
@TheAngryByrd
Copy link
Collaborator

Are there any additional tests we should add? cc @cmeeren

@cmeeren
Copy link
Contributor

cmeeren commented Oct 18, 2019

No idea. It's been so long, and the tests in FsToolkit.ErrorHandling seems to be written/structured/refactored differently (using Expecto) than when we did the merge, so I have no idea what tests are currently in FsToolkit.ErrorHandling. My best suggestion would be that you simply investigate the tests and see if the behaviour they test are covered by your tests.

I'm mostly concerned about the CE tests (Result and AsyncResult); the helpers are more of an "it compiles, it works" variant.

@TheAngryByrd
Copy link
Collaborator

Ok until we have something more actionable, i'm gonna close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheAngryByrd @cmeeren @demystifyfp