Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force binding on top wrapper #86

Closed
TheAngryByrd opened this issue Jun 9, 2020 · 3 comments · Fixed by #87
Closed

Force binding on top wrapper #86

TheAngryByrd opened this issue Jun 9, 2020 · 3 comments · Fixed by #87
Labels
bug Something isn't working

Comments

@TheAngryByrd
Copy link
Collaborator

With the introduce of the Source members in #83, it's now not possible to tell the binding to handle only the Async<_> part of the Async<Result<_,_>> in a CE.

Example:

asyncResult {
    let! (r : Result<_,_>) = AsyncResult.retn innerData
    Expect.equal r (Ok innerData) "Should be ok"
}

Will no longer compile.

@TheAngryByrd TheAngryByrd added the bug Something isn't working label Jun 9, 2020
@piaste
Copy link

piaste commented Jun 23, 2020

👍

Just found this broke some of our code after running a test paket update. Will be pinning to 1.3.1 until a fix or a workaround.

@TheAngryByrd
Copy link
Collaborator Author

Yeah I can fix this one pretty easily. Let me get to that.

TheAngryByrd pushed a commit to TheAngryByrd/FsToolkit.ErrorHandling that referenced this issue Jun 23, 2020
Allows for binding the outer async for complex workflows
@TheAngryByrd TheAngryByrd mentioned this issue Jun 23, 2020
TheAngryByrd pushed a commit that referenced this issue Jun 23, 2020
Allows for binding the outer async for complex workflows
@piaste
Copy link

piaste commented Jun 24, 2020

Thank you, 1.4.1 fixes that.

After updating I've found another breaking change, but it's a little more complicated. I'll open a separate issue.

TheAngryByrd added a commit that referenced this issue Jul 2, 2020
This reverts commit 9ee69d0.
TheAngryByrd added a commit that referenced this issue Jul 2, 2020
This reverts commit 9ee69d0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants