Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table sort icons not rendered #201

Merged
merged 1 commit into from Nov 4, 2021
Merged

fix: table sort icons not rendered #201

merged 1 commit into from Nov 4, 2021

Conversation

kevinhinterlong
Copy link
Contributor

In this PR:

Fixes table sort icons not rendering

Screenshot(s):

Before

none

After

default descend ascend

Pre-Merge Checklist:

Reviewer # 1

  • Review Source code.
  • Review Test code.
  • Review Snapshot.
  • Review PR Storybook.

NOTE: To review PR Storybook for the last build, download PR storybook from CI build Artifacts.

PR Owner

  • Build Status Pipeline is green.

@kevinhinterlong kevinhinterlong mentioned this pull request Oct 24, 2021
Merged
@kevinhinterlong kevinhinterlong marked this pull request as ready for review October 25, 2021 15:01
chasturansky
chasturansky approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@chasturansky chasturansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chasturansky chasturansky merged commit 09b8585 into denali-design:master Nov 4, 2021
@denali-bot
Copy link
Collaborator

🎉 This PR is included in version 2.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkusa jkusa jkusa approved these changes

@chasturansky chasturansky chasturansky approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinhinterlong @denali-bot @jkusa @chasturansky