Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: addon name not set when discovering blueprints #51

Merged
merged 1 commit into from
Mar 8, 2018
Merged

fix: addon name not set when discovering blueprints #51

merged 1 commit into from
Mar 8, 2018

Conversation

knownasilya
Copy link
Member

Should resolve denali-js/core#435

davewasmer
davewasmer approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@davewasmer davewasmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'll merge this in shortly (going to coordinate with some local changes I'm about to publish)

@knownasilya
Copy link
Member Author

knownasilya commented Mar 7, 2018 •
edited

@davewasmer any chance you could merge this? Makes it hard to experiment 😄

@davewasmer davewasmer merged commit c507227 into denali-js:master Mar 8, 2018
@knownasilya knownasilya deleted the patch-2 branch March 8, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davewasmer davewasmer davewasmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default addon blueprint never called when using denali install
2 participants
@knownasilya @davewasmer