Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seed browser initial revision #1166

Merged
merged 6 commits into from
Aug 26, 2021
Merged

feat: seed browser initial revision #1166

merged 6 commits into from
Aug 26, 2021

Conversation

jonathanyeung
Copy link
Contributor

Initial Revision of Seed Browser.

Haven't implemented tests yet, so still in draft.

@jonathanyeung jonathanyeung marked this pull request as draft August 18, 2021 12:05
@jonathanyeung jonathanyeung marked this pull request as ready for review August 19, 2021 14:30
<PageHeader
className={seedStyles.siteHeader}
title="Dendron Seed Registry"
subTitle="Add Knowledge Bases to your Workspace"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the subtitle here to something shorter/more catchy. eg. "A Better way to Know"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that might be good for a browser version of this view, but for the VS Code version I think something a little more informative of what the seeds are for would be better for users? My intention here was to give a hint as to what clicking on 'Add Seed' button would do.

packages/plugin-core/src/commands/SeedCommandBase.ts Outdated Show resolved Hide resolved
packages/plugin-core/src/workspace/workspaceInitializer.ts Outdated Show resolved Hide resolved
packages/dendron-next-server/pages/vscode/seed-browser.tsx Outdated Show resolved Hide resolved
@kevinslin
Copy link
Member

let me know when you think this is ready to review again. also reminder to resolve conversations as they get addressed

@jonathanyeung
Copy link
Contributor Author

let me know when you think this is ready to review again. also reminder to resolve conversations as they get addressed

Ready for review again - ty. Typically I let the commenter resolve the comment thread as a way to 'sign-off' on the thread, but I'm fine with either pattern.

@kevinslin
Copy link
Member

cool, this looks good. can you rebase from master, resolve conflicts and merge?

@jonathanyeung jonathanyeung merged commit 588fba0 into master Aug 26, 2021
@jonathanyeung jonathanyeung deleted the feat/seed-browser branch August 26, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants