-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: seed browser initial revision #1166
Conversation
<PageHeader | ||
className={seedStyles.siteHeader} | ||
title="Dendron Seed Registry" | ||
subTitle="Add Knowledge Bases to your Workspace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the subtitle here to something shorter/more catchy. eg. "A Better way to Know"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that might be good for a browser version of this view, but for the VS Code version I think something a little more informative of what the seeds are for would be better for users? My intention here was to give a hint as to what clicking on 'Add Seed' button would do.
let me know when you think this is ready to review again. also reminder to resolve conversations as they get addressed |
Ready for review again - ty. Typically I let the commenter resolve the comment thread as a way to 'sign-off' on the thread, but I'm fine with either pattern. |
cool, this looks good. can you rebase from master, resolve conflicts and merge? |
bcc9ce2
to
8ba2f2b
Compare
Initial Revision of Seed Browser.
Haven't implemented tests yet, so still in draft.