feat: github publish to create new issue #1206
Conversation
| }); | ||
| repositoryId = result.repository.id; | ||
| } catch (error: any) { | ||
| throw new DendronError({ message: stringifyError(error) }); |
There was a problem hiding this comment.
Can you add Severity.Minor to the DendronError? Same below.
| /** | ||
| * method to get the repository id | ||
| */ | ||
|
|
There was a problem hiding this comment.
nit: delete blank line. I'm not sure if Intellisense will pick up the docstring if there's a space here?
There was a problem hiding this comment.
Intellisense can pickup the docstring even if there is a blank space. Still deleting to maintain a common pattern.
| @@ -98,6 +99,7 @@ export class PublishPodCommand extends BaseCommand< | |||
| } else { | |||
| window.showInformationMessage("contents copied to clipboard"); | |||
| } | |||
| await new ReloadIndexCommand().execute(); | |||
There was a problem hiding this comment.
Curious - what happened that requires a reload index?
There was a problem hiding this comment.
After we create the issue, the note is updated with url and issueID in the frontmatter.
While adding some modification to the note(either body or frontmatter) afterwards, I could see no note found error, which gets removed after I ran Reload Index.
There was a problem hiding this comment.
Interesting - would you mind creating a scratch note in our workspace detailing this issue? Seems like a bug.
https://www.loom.com/share/1eb4948407b04f34b854aa0fdbc78032?sharedAppSource=personal_library