Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support collection options in nextjs publishing #1277

Merged
merged 11 commits into from
Sep 3, 2021

Conversation

hikchoi
Copy link
Contributor

@hikchoi hikchoi commented Sep 3, 2021

feat: support collection options in nextjs publishing

This change adds support for the site configuration has_collection and related collection options to nextjs publishing.

Docs PR: https://wiki.dendron.so/notes/e4ea4fe3-0350-492e-863a-687d9fc15993.html

This implements collection options to be on par with the existing 11ty publishing and does not require documentation update.


Pull Request Checklist

You can go to dendron pull requests to see full details for items in this checklist.

General

Quality Assurance

  • [~]add a test for the new feature
  • make sure all the existing tests pass
  • do a spot check by running your feature with our test workspace
  • after you submit your pull request, check the output of our integration test and make sure all tests pass
    • NOTE: if you running mac/linux, check the windows output and vice versa if you are developing on windows

Special Cases

  • [~] if your tests changes an existing snaphot, make sure that snapshots are updated
  • [~] if you are adding a new language feature (graphically visible in vscode/preview/publishing), make sure that it is included in test-workspace. We use this to manually inspect new changes and for auto regression testing

Docs

  • Make sure that the PR title follows our commit style
  • Please summarize the feature or impact in 1-2 lines in the PR description
  • [~] If your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

@hikchoi
Copy link
Contributor Author

hikchoi commented Sep 3, 2021

doing some clean ups and refactoring. switching back to draft.

@hikchoi hikchoi marked this pull request as ready for review September 3, 2021 09:07
@kevinslin kevinslin merged commit ddaedd4 into master Sep 3, 2021
@kevinslin kevinslin deleted the feat/nextjs-has-collection branch September 3, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants