Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight same file wikilinks, wildcard references, links with anchors #1306

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

SeriousBug
Copy link
Contributor

Same file wikilinks and references ([[#foo]]) and wildcard references (![[foo.*]]) are now highlighted as correct links (although no checks are performed for wildcard references).

Wikilinks and references with anchors ([[note#foo]] or ![[note#foo:#bar]]) are now highlighted as broken if the anchor is broken (for example, note has no header # foo).

Pull Request Checklist

You can go to dendron pull requests to see full details for items in this checklist.

General

Quality Assurance

  • add a test for the new feature
  • make sure all the existing tests pass
  • do a spot check by running your feature with our test workspace
  • after you submit your pull request, check the output of our integration test and make sure all tests pass
    • NOTE: if you running mac/linux, check the windows output and vice versa if you are developing on windows

Special Cases

  • if your tests changes an existing snaphot, make sure that snapshots are updated
  • if you are adding a new language feature (graphically visible in vscode/preview/publishing), make sure that it is included in test-workspace. We use this to manually inspect new changes and for auto regression testiing

Docs

  • Make sure that the PR title follows our commit style
  • Please summarize the feature or impact in 1-2 lines in the PR description
  • If your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Example PR Description

# feat: capitalize all foos

This changes capitalizes all occurences of `foo` to `Foo` 

Docs PR: <URL_TO_DOCS_PR>

Special Cases

First Time PR

  • sign the CLA which will be prompted by our github bot after you submit the PR
  • add your discord alias in the review so that we can give you the horticulturalist badge in our community

Analytics

  • if you are adding analytics related changes, make sure the Telemetry docs are updated

…nchors

Same file wikilinks and references (`[[#foo]]`) and wildcard references (`![[foo.*]]`) are now highlighted as correct links (although no checks are performed for wildcard references).

Wikilinks and references with anchors (`[[note#foo]]` or `![[note#foo:#bar]]`) are now highlighted as broken if the anchor is broken (for example, `note` has no header `# foo`).
@SeriousBug SeriousBug marked this pull request as ready for review September 8, 2021 04:12
@kevinslin kevinslin merged commit 956aa2a into master Sep 8, 2021
@kevinslin kevinslin deleted the fix/same-file-wildcard-link-highlight branch September 8, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants