fix: decode urlencoded spaces in asset path before opening

[hikchoi]

fix: decode urlencoded spaces in asset path before opening

This PR:

• fixes an issue with asset paths not opening correctly with the system's default app when there is a urlencoded space (%20) in the filename.

Manual testing

• Since this is not straightforward to integ-test, I'm doing the following:

1. open dendron.ref.assets in test-workspace
2. open preview
3. click on link to asset with space
4. confirm opening in default app

Pull Request Checklist

If this is your first time submitting a pull request to Dendron, copy and paste the full Dendron Review Checklist into this request and check off each item as necessary.

This template contains the short checklist which is used by the Dendron core team.

Testing

• [~] Write Tests
• Confirm existing tests pass
• Confirm manual testing
• [~] If your tests changes an existing snapshot, make sure that snapshots are updated
• If you are adding a new language feature (graphically visible in VS Code/preview/publishing), make sure that it is included in the test workspace

Docs

• [~] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Analytics

• [~] if you are adding analytics related changes, make sure the Telemetry docs are updated

[hikchoi]

confirmed manual testing in

• mac
• windows
• linux

[hikchoi]

related: #2228

[hikchoi]

madge reports no additional circ dependencies

[kevinslin]

can we have a test for this?

[hikchoi]

can we have a test for this?

Do you have any suggestions on how to write an integ test for this?

The behavior itself is triggered from the webview, which the plugin-core does listens to. the end result we want to verify is that a system default app has been used to open an asset file.

I can test if the path that we get at the end would be properly decoded, but if there's anything else that I'm blanking on here let me know.

nevermind. We already have some existing tests. I'll add more to that

[kevinslin]

this looks good. can you rename ShowPreview.test.ts to PreviewLinkHandler.test.ts to make it more obvious for the next person?