Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publishing): Search Bar Results to not stay anchored to the search bar when scrolling up #2292

Merged

Conversation

eleweek
Copy link
Contributor

@eleweek eleweek commented Jan 26, 2022

fix(publishing): Search Bar Results to not stay anchored to the search bar when scrolling up

Uses information from the antd's FAQ: https://ant.design/docs/react/faq

image

Testing

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Analytics

  • if you are adding analytics related changes, make sure the Telemetry docs are updated

@auto-assign auto-assign bot requested a review from kevinslin January 26, 2022 20:37
@eleweek eleweek force-pushed the fix/search-bar-results-not-stay-anchored-to-the-search-bar branch 2 times, most recently from f380072 to b7d228f Compare January 27, 2022 14:43
@kevinslin
Copy link
Member

approved the pull request. can you just make sure the title of the PR match our commit style? (use lookup in your workspace to find [[Commit Style|dendron://dendron.docs/dev.process.review#commit-style]])

@eleweek eleweek changed the title Fixes #2128: Search Bar Results to not stay anchored to the search bar when scrolling up fix(publishing): Search Bar Results to not stay anchored to the search bar when scrolling up Jan 27, 2022
@eleweek eleweek force-pushed the fix/search-bar-results-not-stay-anchored-to-the-search-bar branch from b7d228f to 0e7a6ff Compare January 27, 2022 16:30
@kevinslin kevinslin merged commit 32b09b0 into master Jan 27, 2022
@kevinslin kevinslin deleted the fix/search-bar-results-not-stay-anchored-to-the-search-bar branch January 27, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants