Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-apply windows hover preview image fix & improve hover preview performance #2312

Merged
merged 17 commits into from
Feb 3, 2022

Conversation

SeriousBug
Copy link
Contributor

@SeriousBug SeriousBug commented Jan 31, 2022

Pull Request Checklist

This PR:

  • Re-applies the hover preview Windows image fix that was reverted here: 7890c01
  • Extends the /notes/render engine API to allow overriding the destination and flavor, then moves the hover preview rendering to the engine
  • Removes most MDUtilsV4 usages from note reference rendering, improves performance by avoiding some unnecessary processor cloning and avoiding re-parsing the referenced region.
  • Some tests have been cleaned up to not use MDUtilsV4.

I was originally attempting to remove all MDUtilsV4 usages from note reference rendering, but this was causing errors with some tests. The issue was MDUtilsV4 usages in tests, but fixing those required even more fixes everywhere else. I managed to fix some, but eventually gave up and reintroduced the compatibility back into note reference rendering.

Testing

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Analytics

  • if you are adding analytics related changes, make sure the Telemetry docs are updated

Kaan Genc added 4 commits January 31, 2022 03:02
Copy link
Member

@kevinslin kevinslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super excited about these changes :)

@SeriousBug SeriousBug changed the title fix: re-apply windows hover preview image fix & improve hover performance fix: re-apply windows hover preview image fix & improve hover preview performance Feb 1, 2022
@SeriousBug SeriousBug marked this pull request as ready for review February 1, 2022 18:51
@auto-assign auto-assign bot requested a review from kevinslin February 1, 2022 18:51
@SeriousBug SeriousBug marked this pull request as draft February 1, 2022 18:58
@SeriousBug SeriousBug marked this pull request as ready for review February 2, 2022 08:53
@kevinslin kevinslin merged commit 103655e into master Feb 3, 2022
@kevinslin kevinslin deleted the fix/windows-hover-preview-issue branch February 3, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants