Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): correctly detect DENDRON_RELEASE_VERSION using both marketplace and package.json #2320

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

eleweek
Copy link
Contributor

@eleweek eleweek commented Feb 1, 2022

fix(dev): correctly detect DENDRON_RELEASE_VERSION using both marketplace and package.json

Currently it gets it from package.json. The updated version gets the latest version from package.json and the marketplace by running (npx vsce show dendron.nightly --json). It concates both things and uses sort -rn | head -n 1 to select the latest version.

I manually tested the command by running it separately in my shell with various versions in package.json.

Testing

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Analytics

  • if you are adding analytics related changes, make sure the Telemetry docs are updated

Copy link
Member

@kevinslin kevinslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its okay to do this as a quick fix. can we add a followup task to introduce a cli method?
we now have the nightly version logic duplicated in here as well as in getIncrementedVerForNightly. we should make it as part of the dev cli

dendron dev get-incremented-ver-for-nightly

then we can use it in just one place as well.
can you add a task according to [[Creating New Issues|dendron://dendron.handbook/area.team.sop.create-new-issue]] ? (you'll need to run Sync Workspace as well as sync you workspace repo separately to get the updated task config)
note that you won't be able to do the last step of exporting to airtable yet, just ping me when its done and i'll make sure its exported

@kevinslin
Copy link
Member

heads up that this is another chore task since its not user facing :)

(if its not useful in a user facing changelog, it should be chore)

@kevinslin kevinslin merged commit cb342b2 into master Feb 1, 2022
@kevinslin kevinslin deleted the fix/nightly-build-bump-version branch February 1, 2022 20:46
@eleweek
Copy link
Contributor Author

eleweek commented Feb 1, 2022

@kevinslin Ah got it. Sorry for the misclassification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants