Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preview opens wrong path on Windows #2326

Merged
merged 2 commits into from
Feb 2, 2022
Merged

fix: preview opens wrong path on Windows #2326

merged 2 commits into from
Feb 2, 2022

Conversation

SeriousBug
Copy link
Contributor

Fixes a couple issues:

  • Preview would open the wrong path on Windows (Uri.path instead of Uri.fsPath)
  • When opened from the command bar, preview would open existing notes as non-note files

Also added automated tests for the preview to hopefully catch these issues in the future.

@auto-assign auto-assign bot requested a review from kevinslin February 2, 2022 00:22
@kevinslin kevinslin merged commit 6ae66bc into master Feb 2, 2022
@kevinslin kevinslin deleted the fix/preview-bad-file-open-windows branch February 2, 2022 00:44
@SeriousBug SeriousBug mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinslin kevinslin kevinslin approved these changes

Assignees

@kevinslin kevinslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SeriousBug @kevinslin