fix(pod): acknowledge cli args for publish pod #2352

Harshita-mindfire · 2022-02-03T15:06:08Z

Related to : #2345

packages/dendron-cli/.vscode/tasks.json

packages/dendron-cli/src/commands/pod.ts

packages/dendron-cli/.vscode/tasks.json

hikchoi

Some small nitpick and a Q, but otherwise looks good

Harshita-mindfire marked this pull request as ready for review February 3, 2022 15:25

auto-assign bot requested a review from kevinslin February 3, 2022 15:25

auto-assign bot assigned kevinslin Feb 3, 2022

kevinslin requested a review from hikchoi February 3, 2022 16:30

fix(pod): acknowledge cli args for publish pod

f45a1a3

Harshita-mindfire force-pushed the fix/publish-pod-to-respect-cli-args branch from 5ce7db0 to f45a1a3 Compare February 3, 2022 17:46

kevinslin requested changes Feb 4, 2022

View reviewed changes

packages/dendron-cli/.vscode/tasks.json Outdated Show resolved Hide resolved

Harshita-mindfire mentioned this pull request Feb 6, 2022

update(doc): add cli tasks in dev.process dendronhq/dendron-docs#17

Merged

hikchoi reviewed Feb 7, 2022

View reviewed changes

packages/dendron-cli/src/commands/pod.ts Show resolved Hide resolved

packages/dendron-cli/.vscode/tasks.json Outdated Show resolved Hide resolved

hikchoi suggested changes Feb 7, 2022

View reviewed changes

fix: resolved PR comments

221ccdc

Harshita-mindfire force-pushed the fix/publish-pod-to-respect-cli-args branch from f5d96d6 to 221ccdc Compare February 7, 2022 09:14

kevinslin approved these changes Feb 7, 2022

View reviewed changes

hikchoi approved these changes Feb 8, 2022

View reviewed changes

kevinslin merged commit b5d1f15 into master Feb 9, 2022

kevinslin deleted the fix/publish-pod-to-respect-cli-args branch February 9, 2022 15:22

Provide feedback