Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schemas): Do not include stubs as part of template suggestions when applying a template #2357

Merged
merged 1 commit into from
Feb 3, 2022
Merged

fix(schemas): Do not include stubs as part of template suggestions when applying a template #2357

merged 1 commit into from
Feb 3, 2022

Conversation

tma66
Copy link
Contributor

@tma66 tma66 commented Feb 3, 2022 •
edited

Bug

  1. foo exists in vault 1
  2. foo.two exists in vault 2
  3. Schema references template called foo
  4. When creating a new note that matches the schema, body from foo in vault 1 should be applied. However, foo from vault 2 gets suggested b/c it is an stub note type

Fix
Filter out stub notes when suggesting template notes

@tma66 tma66 marked this pull request as ready for review February 3, 2022 22:40
@auto-assign auto-assign bot requested a review from kevinslin February 3, 2022 22:40
@kevinslin kevinslin merged commit a746e9c into master Feb 3, 2022
@kevinslin kevinslin deleted the fix/schema-do-not-prompt-stubs-for-templates branch February 3, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinslin kevinslin Awaiting requested review from kevinslin

Assignees

@kevinslin kevinslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tma66 @kevinslin