chore: avoid workspace watcher crashing if folder is deleted #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like a build error |
|
My bad, fixed now. |
hikchoi
reviewed
Feb 7, 2022
Looks like there are 12 references to the deprecated method. Could we try to migrate those instances instead? Then, we can also clean up |
|
My bad, I was trying to fix the issue causing the overload of errors in sentry and tried to make the fix as quickly as possible. The deprecated function is fully removed now. |
added 2 commits
February 8, 2022 02:37
|
This PR drops the total circular dependency count from 136 to 123. |
kevinslin
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkspaceWatcherwas using the deprecatedWorkspaceService.isPathInWorkspaceto check if something is in workspace. This function doesthis.config, which runsWorkspaceService.getOrCreateConfig, which will attempt to read the config file, or write it if the config file is missing.If the folder that should contain the config file is missing, this will cause a
ENOENTerror.I think this can happen if the user loads up a Dendron workspace, but then deletes the folder that contains the workspace while VSCode is still running.