Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): skip adding asset prefix to images with web url #2362

Merged
merged 3 commits into from
Feb 7, 2022
Merged

fix(publish): skip adding asset prefix to images with web url #2362

merged 3 commits into from
Feb 7, 2022

Conversation

Harshita-mindfire
Copy link
Contributor

@Harshita-mindfire Harshita-mindfire commented Feb 4, 2022 •
edited

Pull Request Checklist

Related issue #2356 and #2355

Testing

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Analytics

  • if you are adding analytics related changes, make sure the Telemetry docs are updated

@Harshita-mindfire Harshita-mindfire changed the title fix(pods): skip adding asset prefix to remote images fix(publish): skip adding asset prefix to remote images Feb 4, 2022
@Harshita-mindfire Harshita-mindfire marked this pull request as ready for review February 6, 2022 21:24
@auto-assign auto-assign bot requested a review from kevinslin February 6, 2022 21:24
@Harshita-mindfire Harshita-mindfire changed the title fix(publish): skip adding asset prefix to remote images fix(publish): skip adding asset images h Feb 6, 2022
@Harshita-mindfire Harshita-mindfire changed the title fix(publish): skip adding asset images h fix(publish): skip adding asset prefix to images with web url Feb 6, 2022
@jonathanyeung jonathanyeung self-requested a review February 7, 2022 06:20
@kevinslin kevinslin merged commit 11cf84c into master Feb 7, 2022
@kevinslin kevinslin deleted the fix/skip-adding-assetPrefix-to-remote-images branch February 7, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeriousBug SeriousBug SeriousBug left review comments

@kevinslin kevinslin kevinslin approved these changes

@jonathanyeung jonathanyeung jonathanyeung approved these changes

Assignees

@kevinslin kevinslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Harshita-mindfire @kevinslin @SeriousBug @jonathanyeung