The ()s in the url's image cause error with Dendron's extended image parser

[andrey-jef]

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

• Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
• Lookup. Dendron's Lookup Command
• Views. Dendron Preview, Tree View, Side Panels in the UI
• Schema. Dendron Schemas
• Pod. Data import from / export to Dendron
• Publish. External Site Publish
• Markdown. Markdown features, such as syntax support and features

Describe the bug

When appending the css properties to an image, instead of applying the properties, Dendron shows the css text next to image. This error happens only with a specific url.

To Reproduce

Steps to reproduce the behavior:

1. Create a markdown note with embedded image url

Example
![example-current-liabilities](https://www.investopedia.com/thmb/aEVczlh4Rlnoc7CD-tyvgOKJW0g=/660x0/filters:no_upscale():max_bytes(150000):strip_icc():format(webp)/dotdash_Final_Current_Liabilities_Sep_2020-01-6515e265cfd34787ae2b0a30e9f1ccc8.jpg){max-width: 300px, display: block, margin: 0 auto}

• image url:

  https://www.investopedia.com/thmb/aEVczlh4Rlnoc7CD-tyvgOKJW0g=/660x0/filters:no_upscale():max_bytes(150000):strip_icc():format(webp)/dotdash_Final_Current_Liabilities_Sep_2020-01-6515e265cfd34787ae2b0a30e9f1ccc8.jpg

• appended css properties:

  {max-width: 300px, display: block, margin: 0 auto}

2. Open Dendron Preview to show the note

Expected behavior

The css properties should be applied to image display.

Screenshots

Desktop (please complete the following information)

• OS: Win 10
• Browser (if with published websites; include version): Opera, Version:84.0.4316.31
• Versions (all that apply to bug):
  • Dendron Extension: v0.85.0
  • VS Code version: VS Codium v1.65.2
  • Dendron CLI:

Additional context

comment from SeriousBug in discord: the ()s in the url must be throwing off our extended image parser, so it falls back to the default parser which doesn't have the extended properties

[Harshita-mindfire]

Thanks for reporting the bug. We will let you know when this is fixed 🙏

[SeriousBug]

Hi! Thanks for the report, we have a fix coming which should be out soon.

In the meantime, I realized you can encode the parenthesis to make this work, by replacing ( with %28 and ) with %29. For example,

![alt](https://upload.wikimedia.org/wikipedia/commons/thumb/7/75/Pescatorea_%28Plate_XXIII%29_BHL36081367.jpg/411px-Pescatorea_%28Plate_XXIII%29_BHL36081367.jpg){ width: "300px" }

If you go to that link, you'll see that the original URL has ( and ) characters in it. The image will show up in the preview.

[andrey-jef]

Hi! Thanks for the report, we have a fix coming which should be out soon.

In the meantime, I realized you can encode the parenthesis to make this work, by replacing ( with %28 and ) with %29. For example,

![alt](https://upload.wikimedia.org/wikipedia/commons/thumb/7/75/Pescatorea_%28Plate_XXIII%29_BHL36081367.jpg/411px-Pescatorea_%28Plate_XXIII%29_BHL36081367.jpg){ width: "300px" }

If you go to that link, you'll see that the original URL has ( and ) characters in it. The image will show up in the preview.

As u saw in my screenshot, the image can be displayed (but without css properties being applied) in the preview and published page. The problem is that the text of css properties will be appended next to the image.

Thanks for the workaround. It works as expected

[SeriousBug]

This has been fixed in Dendron 0.88. Could you please try it after updating?

[andrey-jef]

This has been fixed in Dendron 0.88. Could you please try it after updating?

hmm, just recheck with dendron updated to v0.88.0. The problem still persisted, in both Preview and published page, as shown in the screencap below. Or do I need to modify anything?

in published page

in Preview

[SeriousBug]

Ah, I think our release notes were incorrect on this. My bad, looks like it will be fixed in the next version.

[SeriousBug]

Sorry again for the confusion, this has been merged with Dendron 0.89.