Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent fatal errors in Open Backup Command and Run Migration Command in native workspaces #2607

Merged
merged 4 commits into from Mar 22, 2022
Merged

fix: Prevent fatal errors in Open Backup Command and Run Migration Command in native workspaces #2607

merged 4 commits into from Mar 22, 2022

Conversation

hikchoi
Copy link
Contributor

@hikchoi hikchoi commented Mar 22, 2022

fix: Prevent fatal errors in Open Backup Command and Run Migration Command in native workspaces

This PR:

  • Fixes an error that happens during _setupCommands with OpenBackupCommand by defering backup service initialization to execute-time
  • Fixes an error which causes Run Migration command to crash if user is in a native workspace.
    • Correctly handles the case when workspace settings do not exist.
  • Adds test to verify Run Migration works in native workspaces
  • Removes the use of legacy testing harness in RunMigrationCommand.test.ts

@auto-assign auto-assign bot requested a review from kevinslin March 22, 2022 08:24
@kevinslin kevinslin merged commit dce17fe into master Mar 22, 2022
@kevinslin kevinslin deleted the fix/native-workspace-regression branch March 22, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinslin kevinslin kevinslin approved these changes

Assignees

@kevinslin kevinslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hikchoi @kevinslin