Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom menu styling #6

Closed
rajgoel opened this issue Sep 5, 2015 · 6 comments
Closed

Custom menu styling #6

rajgoel opened this issue Sep 5, 2015 · 6 comments

Comments

@rajgoel
Copy link
Contributor

rajgoel commented Sep 5, 2015

Hi Greg,

thanks for the super fast merge of #5. It appears that your changes in styling of cutom panels created some issue when trying to create a menu with similar look-and-feel as the original menu.

This custom menu content

<ul class="slide-menu-items">
<li class="slide-menu-item"><a href="00 - Introduction.html" target="_blank" style="text-decoration:none">Introduction</a></li>
<li class="slide-menu-item"><a href="01 - Notation.html" target="_blank" style="text-decoration:none">Notation</a></li>
<li class="slide-menu-item"><a href="02 - Sets.html" target="_blank" style="text-decoration:none">Sets</a></li>
</ul>

looks like this

screenshot from 2015-09-05 11 36 26

As you can see, the background highlighting is shifted to the right. It looked ok before 8227b0c. Any idea how to best fix this?

Cheers
Asvin

@denehyg
Copy link
Owner

denehyg commented Sep 5, 2015

Yeah, I'm part way through thinking about how slide-menu-items should be handled in custom panels. I've pushed a styling fix that addresses the issue above. I still need to consider how these links are handled with the keyboard interaction, but at least they should appear correct now.

@denehyg denehyg closed this as completed Sep 5, 2015
@rajgoel
Copy link
Contributor Author

rajgoel commented Sep 5, 2015

Great, thanks!

@rajgoel
Copy link
Contributor Author

rajgoel commented Sep 5, 2015

I just realised that the new hideMissingTitles broke proper keyboard interaction (i.e. up/down across missing slide titles does not work).

@denehyg
Copy link
Owner

denehyg commented Sep 5, 2015

Thanks. I'll check it out.

@denehyg
Copy link
Owner

denehyg commented Sep 11, 2015

Hey @rajgoel, I've just pushed changes that should finalise the custom panels with some styling fixes and support for keyboard navigation. Let me know if there are any other issues with it.

@denehyg
Copy link
Owner

denehyg commented Mar 24, 2016

@rajgoel, #7 has been fixed so keyboard navigation should be working again when using hideMissingTitles. Let me know if there are still any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants