Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the script cleaner to change all longform into shortform #12

Open
Questionguy663 opened this issue Apr 12, 2020 · 3 comments
Open

Comments

@Questionguy663
Copy link

Allow the script cleaner to change all longform into shortform automatically

ability = use
endif = ei

and so on to eliminate all long form ways of writing and still keep all "old" scripts compatible with the single simplified uniform way of writing scripts

@axc450
Copy link
Collaborator

axc450 commented Apr 12, 2020

This might be able to built into the beautifier

@patf0rd
Copy link

patf0rd commented Apr 16, 2020

I think it would've been better if the original author never added both commands because I don't think it would be a good idea to remove ability now with all the existing scripts using it. But replacing it with use with the beautifier looks like a good idea to train people :-p

And personally I don't like the suggested ei beautifying (didn't even know this is a thing, but looking into snippets.lua I also see self/enemy/ally and never knew of ally ;-) ). if/endif feels better for understandability/readability of scripts :-)

@axc450
Copy link
Collaborator

axc450 commented Apr 16, 2020

This wouldnt convert into short form - but rather the preferred form. ability, endif, self are all the preferred form. We can deprecate the other functions by posting a warning message in the chat and eventually removing them from the language.

@patf0rd see the new official API for full documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants