Add call to find_library #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be necessary, at least for conda-forge CI.
dengwirda
requested changes
Feb 14, 2020
There was a problem hiding this comment.
Okay, no problem. Can we change that new line to
JLIBNAME = Path(
ctypes.util.find_library("jigsaw.dll"))
just so that jlibname is always a Path object after the if block, regardless of the os...
I've checked this on my Windows + Linux machines, and this seems to work fine. I don't really understand how it was working for me on win before this change though.
|
Sure, done!
It may be something specific about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps Windows find
jigsaw.dllwithout a full path name.A similar call seems not to be needed for Linux and not to work for OSX.
I created a patch identical to this in the conda-forge recipe:
conda-forge/staged-recipes@b8d1bc4